Add missing awaits in MigrationsInfrastructureTestBase #35106
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Nov 14, 2024
|
I tried to find all cases of this a few months ago. Guess I failed! :-) |
|
Nothing like hangs and low-level protocol corruption errors in your EF tests to get your day going :) |
|
We should backport this right? This should affect test stability in a bad way - it causes EFCore.PG tests to fail really systematically, am surprised it doesn't do the same for SQL Server... |
Yes. I have never been able to predict when the failures/hangs from this pattern show up, but they will for someone and it will be infuriating! So yes, fix everywhere. :-D |
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit a3c5677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #34869.
This one was fun to investigate...