[release/9.0] Fix query filters with context accessors #35246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
force-pushed
the
backport-35237
branch
from
c41f581 to
c7e1061
Compare
roji
requested changes
Dec 2, 2024
roji
approved these changes
Dec 2, 2024
|
Approved via email. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35111
Backport of #35237
Description
In EF Core 9 as part of our work on NativeAOT support we reworked piece of query pipeline. This work missed processing of specific node - created when using Query Filters - in expression tree. This results in query shape that we can't translate later.
Customer impact
Customers using Query Filters with this shape experience an exception when running their application.
How found
Customer reported on 9.
Regression
Yes, from 8.
Testing
Tests added.
Risk
Low.