Interpreter GC info stage 1: Use templates to specialize gc info encoder/decoder #113223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… templates that accept a type argument that provides encoding traits
|
Changing the |
…hich one is being used in the debugger
… from reading the code
…_SLOT and NORMALIZE_STACK_SLOT to fix msvc build warnings
jkotas
reviewed
Mar 11, 2025
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Mar 17, 2025
jkotas
reviewed
Mar 17, 2025
jkotas
reviewed
Mar 20, 2025
|
Will batch apply your cast removals and then try and do a cleanup pass myself. Gets a little fussy since clang and MSVC both complain about different implicit conversions from each other, so I have to test on both OSes. |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
OK, I think I found all the unnecessary casts and removed them. I also removed (DE)NORMALIZE_REGISTER since it was a no-op. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have a single GcInfoEncoder/Decoder pair that is configured by platform-specific
#defines ingcinfotypes.h. This makes it unsuitable for use in the interpreter, since the interpreter has its own IR independent of the host/target platforms, and things like the size of an opcode might not match.This is the first step towards being able to configure the encoder/decoder to work for either target code (i.e. x86-64 or arm64) or interpreter code depending on whether the current frame is interpreted or not.
The platform-specific defines now move into a
struct TargetGcInfoEncodingand become eitherconsts orconstexprfunctions, and the encoder/decoder become template classes (TGcInfoEncoder<GcInfoEncoding>andTGcInfoDecoder<GcInfoEncoding>) that accept an encoding. In the future I'll add an encoding for the interpreter, right now there's only the one for the target.To reduce the blast radius of this change I renamed the encoder/decoder when templatizing them, and then added typedefs with the previous names, i.e.
typedef TGcInfoDecoder<TargetGcInfoEncoding> GcInfoDecoder. This opens a path to defining atypedef TGcInfoDecoder<InterpreterGcInfoEncoding> InterpreterGcInfoDecoderin the future or what have you.I think this unavoidably will break the diagnostics repo the next time they update https://github.com/dotnet/diagnostics/tree/main/src/shared but maybe I did my job correctly and it won't?