Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI run only] Use funclets and new EH on win-x86 #113576

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[CI run only] Use funclets and new EH on win-x86 #113576

wants to merge 12 commits into from
+827 −253

Conversation

filipnavara
Copy link
Member

Not for review, move on.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 15, 2025
This was referenced Mar 16, 2025
Open
Open
@filipnavara filipnavara reopened this Mar 17, 2025
@filipnavara filipnavara reopened this Mar 18, 2025
@build-analysis build-analysis bot mentioned this pull request Mar 18, 2025
Open
@filipnavara filipnavara reopened this Mar 18, 2025
@filipnavara filipnavara reopened this Mar 18, 2025
This was referenced Mar 19, 2025
Open
Open
Open
Open
Open
@filipnavara
Copy link
Member Author

Since some people are watching...

Nearly all libraries test pass and CoreCLR test failures are well understood - shortcuts taken in P/Invoke implementation don't handle SuppressGCTransition correctly; x86 has no native code unwind which triggers one of the asserts due to the initial context state; etc. I'll keep this open for a little longer to clean up the remaining issues.

I'll file PRs for things that should be fixed regardless (JIT issues, stack unwinding issues affecting linux-x86, etc.). I'll post some experiment summary once things settle down.

This was referenced Mar 23, 2025
Open
Open
@filipnavara filipnavara mentioned this pull request Mar 24, 2025
Closed
This was referenced Mar 24, 2025
Open
Open
@build-analysis build-analysis bot mentioned this pull request Mar 25, 2025
Open
@filipnavara
Copy link
Member Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Mar 25, 2025
Open
@filipnavara

This comment was marked as resolved.

Sign in to view
@build-analysis build-analysis bot mentioned this pull request Mar 25, 2025
Open
@filipnavara filipnavara mentioned this pull request Mar 26, 2025
Merged
@filipnavara
Copy link
Member Author

filipnavara commented Mar 26, 2025 •
edited
Loading

We fail the PropagateAndRethrowCppException test added in #113323. This will need some extra thought because there's no equivalent of RtlRestoreContext/STATUS_UNWIND_CONSOLIDATE on 32-bit Windows.

UPD: Fixed

This was referenced Mar 26, 2025
Open
Open
@filipnavara
Simplify the last fix
1589ae0
@filipnavara
Move the X86 custom unwinding directly to Thread::VirtualUnwindCallFrame
9a04b92 
implementations. Firstly, this removes the need for the external unwinder
library. Secondly, this remove a lot of unnecessary lookups of EECodeInfo
and related GC info header decoding inefficiencies. It also makes it
easier to update the PCTAddr field in RegDisplay that is x86 specific.
@filipnavara
Fix bugs in last commit
b89163d
@filipnavara
Cleanup assembly split and SoftwareExceptionFrame
fe2120e
@filipnavara
Cross-build fix
025a0e0
@filipnavara
Fix stack alignment on linux-x86
0ce5cea
@filipnavara
linux-x86: Implement R2R P/Invoke helpers
f781019
@filipnavara filipnavara mentioned this pull request Mar 27, 2025
Open
@filipnavara filipnavara mentioned this pull request Mar 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky will be requested when the pull request is marked ready for review MichalStrehovsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-ExceptionHandling-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @jkotas