Support Rate Limiting Trace Sampling #114880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR introduces rate limiting trace sampling support to control the volume of sampling events based on a maximum operations per second limit.
- Added a new RateLimiter class to enforce operation count per second.
- Extended the diagnostic sampling logic in DsesSamplerBuilder and DsesFilterAndTransform to support rate limiting.
- Introduced TestRateLimitingSampler in the test suite to validate the new behavior.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DiagnosticSourceEventSourceBridgeTests.cs | Added new tests for rate limiting sampler behavior. |
| RateLimiter.cs | New implementation of a rate limiting mechanism. |
| DsesSamplerBuilder.cs | Added a method to create a parent rate limiting sampler. |
| DsesFilterAndTransform.cs | Updated filter parsing to support the new rate limiting syntax. |
Files not reviewed (2)
- src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj: Language not supported
- src/libraries/System.Diagnostics.DiagnosticSource/tests/System.Diagnostics.DiagnosticSource.Tests.csproj: Language not supported
tarekgh
added
area-System.Diagnostics.Activity
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity |
This was referenced Apr 22, 2025
rajkumar-rangaraj
approved these changes
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112205