Skip to content

[RISC-V] Simplifying the loop generated in genZeroInitFrameUsingBlockInit #116011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sirntar
Copy link
Member

@sirntar sirntar commented May 27, 2025

This PR is a resubmission of #114003 after fixing some overflow problems. I decided to drop jump encoding changes for this PR to avoid mixing two separate problems (I will resubmit the second part in the future).

As I mentioned in #114003 , a partial unrolling of the loop (and removing rCnt) results in a small performance gain (1.4% on average for coreclr tests and about 0.5% for corefx tests).


Part of #84834, cc @dotnet/samsung

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 27, 2025
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2025
@risc-vv
Copy link

risc-vv commented May 27, 2025

988e2bb is being scheduled for building and testing

GIT: 988e2bb20b4498427c8a5b9c092b2cadf3b0c69c
REPO: dotnet/runtime
BRANCH: main

@risc-vv
Copy link

risc-vv commented May 27, 2025

RISC-V Release-CLR-QEMU: 9075 / 9105 (99.67%)
=======================
      passed: 9075
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9702
VIRTUAL time: 35h 13min 10s 960ms
   REAL time: 36min 3s 53ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 52e7c3de32f3282348b7ee59c09ae3ec062b630e
CI: 8d15504ae1358a01693a7c50a10ed6536bf11989
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants