Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETSDKE2E][Workload Sets] With manifest mode and workload installed, Unhandled exception occurs when running dotnet workload --info using global.json #42581

Closed
NicoleWang001 opened this issue Aug 7, 2024 · 12 comments · Fixed by #42630
Assignees
Labels
Area-Workloads untriaged Request triage from a team member

Comments

@NicoleWang001
Copy link
Member

Describe the bug

With manifest mode and workload installed, Unhandled exception occurs when running 'dotnet workload --info using global.json

To Reproduce

  1. Install .NET 8.0.400 SDK

  2. Install workload eg. aspire
    dotnet workload install aspire
    image

  3. New a global.json and add workloadverion to this file under a new folder

    c:\tt\TestWithGloabalJson
    cd c:\tt\TestWithGloabalJson
    dotnet new global.json
    {
      "sdk": {
        "version": "8.0.400",
        "workloadVersion": "8.0.400"
      }
    }
  1. Run dotnet workload --info and observe

Expected Result

Proper suggestion without any exception. eg. 'dotnet workload list'
image

Actual Result

Unhandled exception:
image

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Workloads untriaged Request triage from a team member labels Aug 7, 2024
@NicoleWang001 NicoleWang001 changed the title [NETSDKE2E][Workload Sets] With manifest mode and workload installed, Unhandled exception occurs when running 'dotnet workload --info using global.json [NETSDKE2E][Workload Sets] With manifest mode and workload installed, Unhandled exception occurs when running dotnet workload --info using global.json Aug 7, 2024
@Forgind
Copy link
Member

Forgind commented Aug 7, 2024

This issue report looks correct to me, but I consider it slightly lower priority because although it shouldn't be an unhandled exception with a call stack, it is still an error scenario, and the error message is correct.

@vdanche
Copy link
Member

vdanche commented Aug 23, 2024

@Forgind Currently this bug not fix in net8.0.402. right?
image

@Forgind
Copy link
Member

Forgind commented Aug 23, 2024

@Forgind Currently this bug not fix in net8.0.402. right? image

It was merged into main last week, so it shouldn't be fixed until 9.0

@vdanche
Copy link
Member

vdanche commented Sep 18, 2024

@Forgind the latest message for NET9 RC2 as below when running dotnet workload --info using globaljson:

dotnet workload --info, error "Unhandled exception: System.IO.FileNotFoundException..." still remains,right?

image

dotnet --info, "Workload version 9.0.100, which was specified in..." not display in dotnet --info, is it expected?
image

dotnet workload --version
image

note:
dotnet workload list
image

@Forgind
Copy link
Member

Forgind commented Sep 18, 2024

@Forgind the latest message for NET9 RC2 as below when running dotnet workload --info using globaljson:

dotnet workload --info, error "Unhandled exception: System.IO.FileNotFoundException..." still remains,right?

image

dotnet --info, "Workload version 9.0.100, which was specified in..." not display in dotnet --info, is it expected? image

dotnet workload --version image

note: dotnet workload list image

I thought it should be in 9.0, but apparently my pr made it in after we branched, so it's in main but not release/9.0.1xx

I'd be in favor of backporting it. @marcpopMSFT, do we still have enough time?

@marcpopMSFT
Copy link
Member

On the one hand, it's a very niche scenario. On the other, we want people to try out workloads in 9.0.100 more broadly. @baronfel @dsplaisted it probably makes sense to take this for GA as the fix looks reasonable enough. Thoughts?
https://github.com/dotnet/sdk/pull/42630/files

@dsplaisted
Copy link
Member

Here's a PR backporting this to 9.0.1xx: #43587

@Forgind
Copy link
Member

Forgind commented Sep 25, 2024

9.0.2xx now, it seems

@vdanche
Copy link
Member

vdanche commented Sep 27, 2024

9.0.2xx now, it seems

On net9 rc2 candidate build --9.0.100-rc.2.24474.11: still display as below after running dotnet workload --info using globaljson
image

@Forgind
Copy link
Member

Forgind commented Sep 27, 2024

9.0.2xx now, it seems

On net9 rc2 candidate build --9.0.100-rc.2.24474.11: still display as below after running dotnet workload --info using globaljson image

That's still 9.0.1xx. It won't be fixed until 9.0.2xx assuming the current PR goes through.

@vdanche
Copy link
Member

vdanche commented Oct 15, 2024

@Forgind Fixed on 9.0.200-preview.0.24512.3 sdk, thanks.
dotnet workload --info
Image
dotnet --info:
Image

Currently, still not fix on net9 rtm sdk(9.0.100-rtm.24514.22)
Image

@Forgind
Copy link
Member

Forgind commented Oct 16, 2024

It won't be fixed on 9.0.100, so there's no need to test that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants