[release/7.0.2xx] Revert hot reload script injection response buffering #29152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
requested review from
captainsafia and
mkArtakMSFT
as code owners
ghost
added
the
|
@MackinnonBuck sounds good. Could you file an issue to revisit this in .NET 8.0? We should consider avoiding the script injection magic in favor of referencing the file in the document directly somehow. |
javiercn
approved these changes
Nov 21, 2022
davidfowl
approved these changes
Nov 21, 2022
|
Are we clear to merge this? |
1 task
|
Hi @marcpopMSFT. Can this be merged or should @MackinnonBuck wait for some green light from you? |
|
Talked to @marcpopMSFT - the branch is open to merge. |
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in memory consumption caused by large responses when debugging with hot reload enabled.
Description
As one of the changes introduced in .NET 7 by #27537, the hot reload script injection middleware now buffers the entire response before performing script injection. This was done to improve script injection reliability, but we recently began receiving reports from customers that were confused by the increase in server memory usage for large responses when debugging with hot reload is enabled.
This PR reverts the buffering behavior but keeps the logging improvements that help customers identify the cause of script injection failures and take steps to fix them.
For .NET 8, we will assess an alternative approach to improve script injection reliability that doesn't involve buffering each response.
Validation
Manual validation + existing automated tests for this scenario.
Risk
Low. This PR simply reverts the offending commit and adds back some of the improved logging behavior with no other changes to functionality.
Fixes dotnet/aspnetcore#45037