Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0.2xx] Avoid warning about empty NuGetPackageRoot in wpftmp projects #44688

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[9.0.2xx] Avoid warning about empty NuGetPackageRoot in wpftmp projects #44688

merged 2 commits into from
Nov 12, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Nov 6, 2024

Fixes #44605.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 6, 2024
@jjonescz jjonescz mentioned this pull request Nov 6, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Nov 6, 2024
Open
@jjonescz jjonescz marked this pull request as ready for review November 7, 2024 13:36
dsplaisted
dsplaisted approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to backport this to 9.0.1xx servicing?

@jjonescz jjonescz mentioned this pull request Nov 8, 2024
Merged
@jjonescz jjonescz changed the title Avoid warning about empty NuGetPackageRoot in wpftmp projects [9.0.2xx] Avoid warning about empty NuGetPackageRoot in wpftmp projects Nov 8, 2024
@jjonescz
Copy link
Member Author

jjonescz commented Nov 8, 2024

Do we also want to backport this to 9.0.1xx servicing?

Backported: #44742

Do I need Tactics approval or something like that?

@dsplaisted
Copy link
Member

Do we also want to backport this to 9.0.1xx servicing?

Backported: #44742

Do I need Tactics approval or something like that?

Yes, you can fill out the approval template which you can refer to here in the description of the PR, and then mark it with the servicing-consider label.

@marcpopMSFT marcpopMSFT merged commit d155b8f into dotnet:release/9.0.2xx Nov 12, 2024
32 checks passed
@jjonescz jjonescz deleted the tearing-wpftmp branch November 13, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

@baronfel baronfel Awaiting requested review from baronfel

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjonescz @dsplaisted @marcpopMSFT