Port a set of test fixes for the templating tests and some feed tests to 9.0.1xx (#45549) #46431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
…plating new tests (#46001)
This was referenced Jan 31, 2025
|
I haven't looked at the changes, but the macOS build is failing with "path already exists" errors. |
This was referenced Feb 4, 2025
joeloff
reviewed
Feb 5, 2025
| @@ -5,7 +5,6 @@ namespace Microsoft.NET.TestFramework | |||
| { | |||
| public static class NuGetConfigWriter | |||
| { | |||
| public static readonly string DotnetCoreBlobFeed = "https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json"; | |||
| public static readonly string AspNetCoreDevFeed = "https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json"; | |||
There was a problem hiding this comment.
Should we even be using myget feeds at this point, even if it's for testing? Unrelated to your change, but it caught my eye
There was a problem hiding this comment.
I'm not sure, I can make a separate pass over trying to get rid of it.
joeloff
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template tests are failing in 9.0.1xx so backporting the changes I made to 2xx to simplify them:
#46405