Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled Test #46661

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled Test #46661

merged 2 commits into from
Feb 10, 2025

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Feb 8, 2025 •
edited
Loading

Fixes #46638

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ILLink untriaged Request triage from a team member labels Feb 8, 2025
@build-analysis build-analysis bot mentioned this pull request Feb 8, 2025
Open
@v-wuzhai v-wuzhai requested a review from marcpopMSFT February 8, 2025 05:39
@v-wuzhai v-wuzhai marked this pull request as ready for review February 8, 2025 05:39
@nagilson nagilson merged commit 43a36e8 into release/8.0.1xx Feb 10, 2025
17 checks passed
@nagilson nagilson deleted the dev/Jason/updateTest branch February 10, 2025 23:57
@marcpopMSFT
Copy link
Member

@v-wuzhai we'll want to revert this when the runtime changes flows back to GH. That'll be on March 11th. Can you make a reminder for yourself to do that. Note that we can probably leave in the CommandResultAssertion change in case we ever need to use ignore results in a test in the future and just modify the test.

@v-wuzhai
Copy link
Member Author

@v-wuzhai we'll want to revert this when the runtime changes flows back to GH. That'll be on March 11th. Can you make a reminder for yourself to do that. Note that we can probably leave in the CommandResultAssertion change in case we ever need to use ignore results in a test in the future and just modify the test.

Sure, I'll remind myself to revert the changes when the runtime changes flow back to GH on March 11th and keep the CommandResultAssertion change.

@v-wuzhai v-wuzhai mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

@nagilson nagilson nagilson approved these changes

Assignees
No one assigned
Labels
Area-ILLink untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-wuzhai @marcpopMSFT @nagilson