This repository was archived by the owner on May 17, 2024. It is now read-only.
Update AddDesktopProperties to add desktop props for all project styles
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
May 13, 2021
|
I will spin up a new release today as well. |
|
Release created, package uploaded and indexing. Should be good to go within a few mins: https://github.com/dotnet/try-convert/releases/tag/v0.7226301 |
|
Awesome; thanks for the quick turnaround, @cartermp! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer ran into an issue where an MSTest project with references to PresentationFramework and PresentationCore wasn't getting a
UseWPFproperty during conversion.This PR updates
AddDesktopPropertiesto allow adding desktop properties for any project styles (not just Windows desktop ones) since other project types (MSTest, for example) could have WPF or WinForms dependencies and benefit from the desktop properties.I've tried to think through if there's any reason we wouldn't want these properties in projects that didn't evaluate to WindowsDesktop project style (which I think will only be MSTest or Custom projects since those are the ones that are checked before desktop currently) and I can't think of anything. Let me know if you can think of any cases where we wouldn't want these added.