Updated function to be compatible with the base one. #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdNadimHossain
requested review from
vincent-gao,
sharmasahil,
anthony-malkoun and
yeniatencio
vincent-gao
approved these changes
Oct 16, 2024
MdNadimHossain
deleted the
task/fix-php-fatal-error-for-override-function-compatibility-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Problem/Motivation
PHP Fatal error: Declaration of Drupal\tide_site\Plugin\Linkit\Substitution\Canonical::getUrl(Drupal\Core\Entity\EntityInterface $entity) must be compatible with Drupal\linkit\Plugin\Linkit\Substitution\Canonical::getUrl(Drupal\Core\Entity\EntityInterface $entity, array $options = []) in /app/docroot/modules/contrib/tide_core/modules/tide_site/src/Plugin/Linkit/Substitution/Canonical.php on line 70Fix
Updated the overriding function.
Related PRs
It is related to the latest linkit module release and this patch to be specific which updates the getUrl function - https://www.drupal.org/project/linkit/issues/3022261
Screenshots
TODO