Skip to content

Changing the color of the facet labels #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

arianacabral
Copy link
Contributor

@arianacabral arianacabral commented Jan 25, 2023

Your repository is absolutely amazing.

When I used the theme with a faceted plot, I noticed that the labels are black (which is the default color, but which makes the labels difficult to see).

Example:

library(ggplot2)
library(palmerpenguins)

theme_set(theme_dracula())

ggplot(penguins, aes(x = island, fill = species)) +
  geom_bar(alpha = 0.8) +
  scale_fill_manual(values = dracula_palette(
    num_col  = nlevels(factor(penguins$species)),
    var_type = "discrete"
  )) +
  facet_wrap(~species, ncol = 1) 

dracula_example_old

So I'm hoping that my change will help this repository.

Change:

strip.text = element_text(face  = "bold", color = "#6272A4"),

dracula_example

I found the repository very interesting. 

When I used the theme with a faceted plot, I noticed that the labels are black (which is the default color, but which makes the labels difficult to see). 

So I'm hoping that my change will help this repository.
@jrdnbradford jrdnbradford self-assigned this Feb 5, 2023
Copy link
Collaborator

@jrdnbradford jrdnbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @arianacabral. I think #6272A4 is the right color for the text in question here.

@jrdnbradford jrdnbradford merged commit 06657f8 into dracula:main Feb 5, 2023
@arianacabral
Copy link
Contributor Author

Thanks @jrdnbradford for taking the time and considering this suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants