Skip to content

Change details #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brewerdaniel-IW opened this issue Dec 6, 2024 · 5 comments
Closed

Change details #6

brewerdaniel-IW opened this issue Dec 6, 2024 · 5 comments
Assignees

Comments

@brewerdaniel-IW
Copy link
Contributor

Hello!

At Convex we use Draftable and would like to use the /{identifier}/change-details endpoint to get a JSON description of the changes.

We already use the Python SDK and we didn't want to create some extra requests-based code to just get this JSON response, also, we don't want to maintain our own version of this package.

I've created a PR so that all can benefit from this new endpoint: #5

Every effort has been made to follow the existing conventions of the repository but very much welcome feedback.

Thanks,

Dan

@PeteOnTheGitHub
Copy link

Hey Dan,

Thanks for your pull request. I will take a look in the coming days.

Cheers,
Pete

@brewerdaniel-IW
Copy link
Contributor Author

Hi Pete,

Any update on this?

Many thanks,

Dan

@PeteOnTheGitHub
Copy link

Hey Dan,

We do appreciate the effort; The intent is to get this merged within the next fortnight. Apologies for the delay.

Regards,
Pete

@rychoo2
Copy link

rychoo2 commented Jan 23, 2025

We are reviewing the PR now. The dropped support for TXT files isn't right. What is the exact issue you're having?
I checked with TXT and it is working correctly for me so I reverted that change.

@rychoo2
Copy link

rychoo2 commented Jan 23, 2025

The change looks good. We only applied a few minor tweaks. We will need to check the failing CI pipeline.

Thank you for your effort.

@rychoo2 rychoo2 closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants