Change Details Endpoint #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rychoo2
reviewed
Jan 23, 2025
rychoo2
reviewed
Jan 23, 2025
draftable/test_client.py
Outdated
| with open("test-files/change-details.json", "r") as f: | ||
| expected_change_details = json.load(f) | ||
|
|
||
| assert change_details.to_dict() == expected_change_details |
There was a problem hiding this comment.
the exact content of changes json is subject to change outside of this library. I am changing the assert to something less strict.
rychoo2
force-pushed
the
feat/change-details-endpoint
branch
from
19a1728 to
0ff4733
Compare
rychoo2
changed the base branch from
main
to
brewerdaniel-IWfeat/change-details-endpoint
rychoo2
merged commit cca6938
into
draftable:brewerdaniel-IWfeat/change-details-endpoint
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
/{identifier}/change-detailsendpoint, it is not available in the SDKChanges
comparisons.change_detailsmethod to retrieve the JSON description of changes from the API.txtto.rtfas.txtfiles do not work on the EU1 endpointNotes