chore: improve partial sync and test #5195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
May 28, 2025
| return ring_buffer_.front().lsn == lsn; | ||
| } | ||
|
|
||
| return ring_buffer_.front().lsn <= lsn && lsn <= ring_buffer_.back().lsn; |
There was a problem hiding this comment.
So much cleaner now...l
kostasrim
commented
May 28, 2025
| // std::string shard_path_; | ||
| // std::unique_ptr<LinuxFile> shard_file_; | ||
| std::optional<base::RingBuffer<JournalItem>> ring_buffer_; | ||
| boost::circular_buffer<JournalItem> ring_buffer_; |
There was a problem hiding this comment.
bye bye std::optional and base::RingBuffer. Welcome boost::circular_buffer :)
kostasrim
commented
May 28, 2025
| return; | ||
|
|
||
| ring_buffer_.emplace(2); | ||
| ring_buffer_.set_capacity(absl::GetFlag(FLAGS_shard_repl_backlog_len)); |
There was a problem hiding this comment.
also works for non power of two now :)
Signed-off-by: kostas <kostas@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces helio
base/ring_bufferwithboost/circular_bufferforsimplicityandcorrectness.base/ring_bufferwithboost/circular_bufferAddresses #5180