Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc quick insert placeholder #4841

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

siam-ese
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Sorry, something went wrong.

@siam-ese siam-ese requested review from jikkai and Jocs as code owners March 15, 2025 10:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

github-actions bot commented Mar 15, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Mar 15, 2025

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 5 seconds
commit  eb13c62
info  For more information, see full report

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 34.12%. Comparing base (0477211) to head (eb13c62).

Files with missing lines Patch % Lines
...-ui/src/services/doc-quick-insert-popup.service.ts 0.00% 23 Missing ⚠️
...ck-insert-ui/src/views/KeywordInputPlaceholder.tsx 0.00% 4 Missing ⚠️
...ick-insert-ui/src/views/QuickInsertPlaceholder.tsx 0.00% 3 Missing ⚠️
...ocs-quick-insert-ui/src/views/QuickInsertPopup.tsx 0.00% 2 Missing ⚠️
.../docs-ui/src/services/doc-popup-manager.service.ts 0.00% 2 Missing ⚠️
.../src/controllers/doc-quick-insert-ui.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4841      +/-   ##
==========================================
- Coverage   34.14%   34.12%   -0.03%     
==========================================
  Files        2621     2623       +2     
  Lines      136845   136875      +30     
  Branches    30391    30394       +3     
==========================================
- Hits        46721    46703      -18     
- Misses      90124    90172      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant