Skip to content

Fix/missing description and broken md layout #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tienshaoku
Copy link

This pr includes two fixes:

50f89af

Issue

Descriptions are missing in the expanded view, which is not a problem on larger screens but confusing on mobile view. For example, for RETURNDATACOPY, without the description it's very confusing (for opcode learners like me) what this Opcode does.

image

Fix

Added description sections to all expanded section, no matter mobile view or not.
I reused descriptions directly referenceItem since descriptions aren't part of md files.

image
  • For full-screen users, having the description in the expanded section is also nice that we don't have to glance to the top-right section for it
image

18ee26f

Issue

For screen width >= 768 && < 1024, the column layout is squeezed together.

image

Fix

Change breakpoints of Input & Output from lg to md s.t. there's not unintended gap when it's md view.

  • width == 768: columns are rather tight but maybe acceptable?
image
  • width == 1023
image

If further improvements should be made to the commits, please lmk and I'm v happy to help since this website serves me (and i believe many) tremendous help for learning about EVM, bytecode and Huff!

Btw the reason why I use mobile view is that I keep the browser on the left and code editor on the right s.t. I can easily write Huff code based on the info on the left, which made me to want to help fix this issue to improve mobile/ smaller screen view users' experience :)

Copy link

vercel bot commented Mar 23, 2025

@tienshaoku is attempting to deploy a commit to the Duneanalytics Team on Vercel.

A member of the Team first needs to authorize it.

@tienshaoku
Copy link
Author

@2xic @TheEdgeOfRage
Hi sorry for tagging, please take a look when you're free, thank you!

@2xic
Copy link
Collaborator

2xic commented Apr 5, 2025

Hey @tienshaoku, this looks good, will test it and review early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants