Skip to content

adding sidenav types + removing unneccesary func #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Feb 4, 2022

Removed scss file since it is no longer necessary.
Moved TabIndex input to the sidenavLink.
Since the TabIndex input has been moved there is no longer a need for a service so it has been removed.
Removed arrow functionality and also responsiveness.

@Jialecl Jialecl linked an issue Feb 4, 2022 that may be closed by this pull request
@aidamag aidamag self-requested a review February 8, 2022 16:46
@aidamag aidamag merged commit 4ceb851 into master Feb 14, 2022
@aidamag aidamag deleted the jialecl-sidenav-types branch February 14, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add types for Sidenav component
2 participants