Skip to content

Error page ignoring error_template changes #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LaocheXe opened this issue Apr 23, 2020 · 3 comments
Closed

Error page ignoring error_template changes #4137

LaocheXe opened this issue Apr 23, 2020 · 3 comments
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening

Comments

@LaocheXe
Copy link
Member

501st website has been up for about 3 years now, using my defaitnzstrap3 theme - I have a custom 404 page set up in the theme templates. (I do keep the files up to date with Github).

Annotation 501st

New site using github files - working on a new theme, using error_template.php in the theme's/templates folder - however, it's not working.

Annotation ewl

I've even tried replacing e107_core/templates/error_template.php with my own - still same thing. I've cleared my browser cache, website cache, and tried it on other PC's and web browsers (Firefox, Chrome, Opera GX).

I even tried applying the 501st error_template to the new site, still no changes. error.php hasn't been updated in 2 years, 3 years for the error_template.php. I don't know what the issue is.

@LaocheXe LaocheXe added the type: bug A problem that should not be happening label Apr 23, 2020
@LaocheXe
Copy link
Member Author

I've even tried editing e107_handlers/error_page_class.php (edit the setPageNotFound() (404) - tried replacing the LAN's with regular text, nothing.

@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Apr 23, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Apr 24, 2020

The first site returns a 404 header.
The second site returns a 501 header.

Still digging..

CaMer0n added a commit that referenced this issue Apr 24, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Apr 24, 2020

Solved. .htaccess was missing, so a 501 was returned.

@CaMer0n CaMer0n closed this as completed Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants