Skip to content

Load Parameters before creating new parameters cause unique_name clashes #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
damskii9992 opened this issue Aug 13, 2024 · 0 comments · Fixed by #49
Closed

Load Parameters before creating new parameters cause unique_name clashes #48

damskii9992 opened this issue Aug 13, 2024 · 0 comments · Fixed by #49
Assignees
Labels
[area] global_object Anything related to the global_object [scope] bug Bug report or fix (major.minor.PATCH)

Comments

@damskii9992
Copy link
Contributor

When starting out a project by loading previously defined parameters from an earlier session, the global_object map gets filled with these unique names and when the user then starts creating new parameters, the unique_name_generator increments the name iterators and eventually causes unique_name crashes with the unique names populated at load time.

This can be solved by incrementing iterators again if the unique_name already exists in the global_object when generating the unique names.

@damskii9992 damskii9992 added [scope] bug Bug report or fix (major.minor.PATCH) [area] global_object Anything related to the global_object labels Aug 13, 2024
@damskii9992 damskii9992 self-assigned this Aug 13, 2024
@damskii9992 damskii9992 linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[area] global_object Anything related to the global_object [scope] bug Bug report or fix (major.minor.PATCH)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant