Skip to content

48 Re-increment unique names if already exists #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

48 Re-increment unique names if already exists #49

merged 1 commit into from
Aug 13, 2024

Conversation

damskii9992
Copy link
Contributor

Fixes an issue with the unique_name generation

@damskii9992 damskii9992 added [scope] bug Bug report or fix (major.minor.PATCH) [area] global_object Anything related to the global_object labels Aug 13, 2024
@damskii9992 damskii9992 linked an issue Aug 13, 2024 that may be closed by this pull request
Load Parameters before creating new parameters cause unique_name clashes #48
Closed
@damskii9992 damskii9992 requested a review from andped10 August 13, 2024 12:30
andped10
andped10 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@andped10 andped10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We are going to decommission ObjectClasses and Variable in foreseeable future, right? If that is not the case additional tests need to be added.

@damskii9992
Copy link
Contributor Author

Looks good to me.

We are going to decommission ObjectClasses and Variable in foreseeable future, right? If that is not the case additional tests need to be added.

Variable should be decommissioned yeah and ObjectClasses should be changed/re-arranged too so that the unique_name_generator is only defined in 1 place.

@damskii9992 damskii9992 merged commit 8d17227 into develop Aug 13, 2024
30 checks passed
@damskii9992 damskii9992 deleted the 48-Re-increment-unique_names-if-already-exists branch August 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot]

@andped10 andped10

Assignees
No one assigned
Labels
[area] global_object Anything related to the global_object [scope] bug Bug report or fix (major.minor.PATCH)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load Parameters before creating new parameters cause unique_name clashes
2 participants
@damskii9992 @andped10