Skip to content

Updating bindings throws errors on value query on Descriptors #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Feb 21, 2025

Noticed when working on EDA.

This is a part of the large(r) slew of PRs for the new EasyDiffraction App update

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko added the [scope] bug Bug report or fix (major.minor.PATCH) label Feb 21, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@henrikjacobsenfys
Copy link
Member

So since this wasn't caught by any tests, I suppose we should write the test that should have caught it?

@rozyczko
Copy link
Member Author

So since this wasn't caught by any tests, I suppose we should write the test that should have caught it?

There are no tests for InterfaceFactoryTemplate at all. I started looking at it but this is a separate project - we need proper coverage for this class, not just one test.

Delegated to #102

@rozyczko rozyczko merged commit 755fc5a into develop Feb 26, 2025
36 checks passed
@rozyczko rozyczko deleted the new_params_fix branch February 26, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[scope] bug Bug report or fix (major.minor.PATCH)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants