Skip to content

slightly reworked API for accessing info about minimizers #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

slightly reworked API for accessing info about minimizers #47

merged 1 commit into from
Aug 8, 2024

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Aug 8, 2024

  • Renamed available_methods to all_methods.
  • Added supported_methods.
  • Made both methods static and required in derived classes.
  • Updated tests.

github-actions[bot]
github-actions bot requested changes Aug 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 self-requested a review August 8, 2024 11:30
andped10
andped10 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@andped10 andped10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rozyczko rozyczko added the [scope] enhancement Adds/improves features (major.MINOR.patch) label Aug 8, 2024
@rozyczko rozyczko merged commit 978d7a4 into develop Aug 8, 2024
28 checks passed
@rozyczko rozyczko deleted the minimizers_api branch August 8, 2024 13:33
rozyczko added a commit to rozyczko/EasyScience that referenced this pull request Aug 15, 2024
@rozyczko
slightly reworked API for accessing info about minimizers (easyscienc…
f9e82e1 
…e#47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@andped10 andped10 andped10 approved these changes

Assignees
No one assigned
Labels
[scope] enhancement Adds/improves features (major.MINOR.patch)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozyczko @andped10