New job #5
Merged
New job #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andped10
approved these changes
Aug 6, 2024
src/easyscience/Objects/Job/Job.py
Outdated
| def calculate_theory(self, *args, **kwargs): | ||
| raise NotImplementedError("calculate_theory not implemented") | ||
| #pass | ||
| # @abstractmethod |
There was a problem hiding this comment.
The summary/info abstract classes will be added later, so I left the code for future reuse.
The calculate_theory abstract method should not be commented out. Fixed.
|
|
||
| from easyscience.Datasets.xarray import xr # type: ignore |
There was a problem hiding this comment.
Are we not moving away from xarray?
There was a problem hiding this comment.
We are, but conversion to scipp in libraries will be done gradually. I could remove the dependency on xarray in EasyScience, though, by deleting type hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual classes for the new job and relevant other things.
Also, changes to the lmfit wrapper fixing circular dependencies.