Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just created terminal has incorrect name #4392

Closed
SkorikSergey opened this issue Mar 10, 2017 · 1 comment
Closed

Just created terminal has incorrect name #4392

SkorikSergey opened this issue Mar 10, 2017 · 1 comment
Assignees
@evidolob
Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@SkorikSergey
Copy link
Contributor

Reproduction Steps:
Start any project
Create a new terminal

Expected behavior:
A new terminal appeared with "Terminal-2" name

Observed behavior:
The terminal name is "Terminal". Next created terminals have names started from "Terminal-2".
Similar behavior happens when start a workspace or after refreshing a page.

Che version: 5.5.0-SNAPSHOT
OS and version: Ubuntu 16.04 LTS
Docker version: 1.12.3
Che install: Docker container
anim
@musienko-maxim musienko-maxim changed the title A second created terminal has not correct name A second created terminal have incorrect name Mar 10, 2017
@musienko-maxim musienko-maxim changed the title A second created terminal have incorrect name A second created terminal has incorrect name Mar 10, 2017
@musienko-maxim musienko-maxim changed the title A second created terminal has incorrect name Just created created terminal has incorrect name Mar 10, 2017
@SkorikSergey SkorikSergey changed the title Just created created terminal has incorrect name Just created terminal has incorrect name Mar 10, 2017
@musienko-maxim musienko-maxim added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 10, 2017
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Mar 13, 2017
@AndrienkoAleksandr AndrienkoAleksandr added team/enterprise status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 13, 2017
@AndrienkoAleksandr
Copy link
Contributor

Main bug: terminal didn't added to the machine tree. In this issue described only side effect of this bug.

@AndrienkoAleksandr AndrienkoAleksandr removed the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 15, 2017
@vkuznyetsov vkuznyetsov added the status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach label Mar 15, 2017
@evidolob evidolob self-assigned this Mar 21, 2017
@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 21, 2017
evidolob pushed a commit that referenced this issue Mar 22, 2017
#4392 change parent node for terminal node
022cc09 
Signed-off-by: Even Vidolob <evidolob@codenvy.com>
@evidolob evidolob added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 22, 2017
@evidolob evidolob mentioned this issue Mar 23, 2017
Merged
evidolob pushed a commit that referenced this issue Mar 24, 2017
#4392 change parent node for terminal node (#4528)
cccae73 
Signed-off-by: Even Vidolob <evidolob@codenvy.com>
tolusha pushed a commit that referenced this issue Mar 24, 2017
#4392 change parent node for terminal node (#4528)
91023fb 
Signed-off-by: Even Vidolob <evidolob@codenvy.com>
JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017
eclipse-che#4392 change parent node for terminal node (eclipse-che#4528)
3d17ca7 
Signed-off-by: Even Vidolob <evidolob@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@evidolob @vparfonov @musienko-maxim @vkuznyetsov @AndrienkoAleksandr @SkorikSergey