[cli] rewrite of che-ip utility #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite che-ip with more helper functions - introduce bats unit tests for each function - For each “supported OS”, we have an output of “ip a show” command and then run against each of this file the tool to check if it performs as expected ./build.sh : build image + run tests (option to skip tests = —skip-tests) ./run.sh : run image ./test.sh : run the unit tests (no need to build the image first) Change-Id: Ic92825d2b427139d52db69f0131bee21d16d3c0f Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/bug
tolusha
approved these changes
Jan 30, 2017
ghost
approved these changes
Jan 30, 2017
riuvshin
approved these changes
Jan 30, 2017
|
@benoitf does those changes means that ip now depends on bats? |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1818/ |
|
@riuvshin for build time yes |
benoitf
added
status/pending-merge
and removed
status/code-review
…re helper functions - introduce bats unit tests for each function - For each “supported OS”, we have an output of “ip a show” command and then run against each of this file the tool to check if it performs as expected Change-Id: I05d1c84d3a13f5be6ccad9af56c5a1bb72c67443 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
TylerJewell
approved these changes
Jan 31, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1829/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* Fix eclipse-che#3941 by rewriting che-ip utility - Rewrite che-ip with more helper functions - introduce bats unit tests for each function - For each “supported OS”, we have an output of “ip a show” command and then run against each of this file the tool to check if it performs as expected ./build.sh : build image + run tests (option to skip tests = —skip-tests) ./run.sh : run image ./test.sh : run the unit tests (no need to build the image first) Change-Id: Ic92825d2b427139d52db69f0131bee21d16d3c0f Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rewrite of che-ip utility
./build.sh : build image + run tests (option to skip tests = —skip-tests)
./run.sh : run image
./test.sh : run the unit tests (no need to build the image first)
note: you may try new utility with command
it requires #3951 for running all bats asserts commands
What issues does this PR fix or reference?
#3941
Changelog and Release Note Information
Changelog
Rewrite che-ip utility and add unit tests for all known use cases (OS/Docker install).
Release Notes: N/A bugfix
Docs Pull Request
none : same behavior than before
Change-Id: Ic92825d2b427139d52db69f0131bee21d16d3c0f
Signed-off-by: Florent BENOIT fbenoit@codenvy.com