CLI - Fix for CHE-3993 - Proper integer comparison #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
TylerJewell
added
the
kind/bug
benoitf
reviewed
Feb 6, 2017
| @@ -87,28 +87,30 @@ cmd_start_check_host_resources() { | |||
| HOST_RAM=$(echo ${HOST_RAM#*:} | xargs) | |||
| HOST_RAM=${HOST_RAM% *} | |||
|
|
|||
| COMPARE=$(echo "$HOST_RAM<$CHE_MIN_RAM" | bc -l) | |||
There was a problem hiding this comment.
we could use awk so we don't need to add another tool inside the image
/ # awk 'BEGIN { print (1.543 >= 5.234) ? 0 : 1}'
1
/ # awk 'BEGIN { print (15.43 >= 5.234) ? 0 : 1}'
0
riuvshin
approved these changes
Feb 6, 2017
Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
|
Per @benoitf request, I removed |
TylerJewell
changed the title
benoitf
approved these changes
Feb 6, 2017
TylerJewell
added
the
severity/P2
|
Build # 1895 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1895/ to view the results. |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* fix integer comparison Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Jewell tjewell@codenvy.com
What does this PR do?
This PR adds a function to the base CLI to use awk to do numerical comparisons. Our default function was having problems if the decimal place was in a different location, and this improvement makes it simpler to do these checks.
This check was being used when comparing RAM and disk sizes to minimums.
What issues does this PR fix or reference?
#3993
Changelog
Add awk function to do numerical comparisons in CLI but reverted by PR #4035.
Release Notes
N/A
Docs PR
N/A