Enable the Tycho Baselineplugin for m2e #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
use_tycho_baseline_plugin
branch
4 times, most recently
from
c68882a to
4a70c7e
Compare
|
Revealed a bug in Tycho 4.0 |
|
Looks good 😃 But I think it would be good to split this into two commits, one to update to Tycho 4.0.0-SNAPSHOT+build adjustments and the second one to introduce the baseline repo. Just to have concerns a bit separated.
I wonder which jar in the M2E build does not have a Manifest? Ah ok, check the logs, it was a dependency^^ |
laeubi
force-pushed
the
use_tycho_baseline_plugin
branch
2 times, most recently
from
3fa8fe1 to
eed4b0e
Compare
laeubi
force-pushed
the
use_tycho_baseline_plugin
branch
2 times, most recently
from
5ec6dfc to
69916ae
Compare
|
@HannesWell any idea why the build fails with version complaint? |
laeubi
force-pushed
the
use_tycho_baseline_plugin
branch
3 times, most recently
from
d6b8a5c to
c5d6d68
Compare
Should work again now, with #1130. |
HannesWell
force-pushed
the
use_tycho_baseline_plugin
branch
from
c5d6d68 to
913ade0
Compare
laeubi
force-pushed
the
use_tycho_baseline_plugin
branch
2 times, most recently
from
9931e14 to
210d905
Compare
HannesWell
force-pushed
the
use_tycho_baseline_plugin
branch
from
210d905 to
51c2865
Compare
laeubi
force-pushed
the
use_tycho_baseline_plugin
branch
from
51c2865 to
512ce55
Compare
- org.eclipse.m2e.lemminx.feature has changed license text - org.eclipse.m2e.pde.feature has upgraded bnd lib - org.eclipse.m2e.sdk.feature includes the changed pde feature
|
I assume the test-failure is not really related to the maven build so we can merge this, all Tycho changes should be available now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the new tycho-baseline-plugin for m2e to see how/if this works out and where Tycho must improve and test it on a real world example.