Add timeout when querying search.maven.org #1197
Conversation
org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/MavenArtifactIdentifier.java
Outdated
Show resolved
Hide resolved
mickaelistria
force-pushed
the
search-timeout
branch
from
848fad9 to
065bec2
Compare
Test Results 196 files ±0 196 suites ±0 27m 1s ⏱️ + 1m 49s For more details on these failures and errors, see this check. Results for commit db871a8. ± Comparison against base commit 6eb17db. ♻️ This comment has been updated with latest results. |
mickaelistria
force-pushed
the
search-timeout
branch
from
065bec2 to
587829b
Compare
mickaelistria
force-pushed
the
search-timeout
branch
from
587829b to
db871a8
Compare
| @@ -82,7 +82,7 @@ | |||
| <dependency> | |||
| <groupId>com.google.code.gson</groupId> | |||
| <artifactId>gson</artifactId> | |||
| <version>2.9.1</version> | |||
| <version>2.10.1</version> | |||
There was a problem hiding this comment.
Please keep the dependency as it is. Due to lsp4j's package imports, that causes TP resolution errors in the workspace: #1146 (comment)
I don't know why it doesn't do that in the CI.
There was a problem hiding this comment.
I don't think this issue is an issue of m2e and that the resolution error in the TP is something m2e should be blamed for. There is nothing that prevents gson 2.9.1 and 2.10.1 to coexist in the same TP. If LSP4J requires 2.9.1, then consumers of LSP4J must provide 2.9.1; without preventing m2e to move to newer version.
There was a problem hiding this comment.
Then please add both versions, because only with 2.10 I can currently not launch an IDE in my m2e workspace.
The update for lsp4j happens in eclipse-lsp4j/lsp4j#689.
There was a problem hiding this comment.
I believe both versions are supposed to be part of the resolved TP: 2.10.1 explicitly changed here, and 2.9.1 as a transitive dependency of LSP4E. Can you check your resolved TP contains both? Then can you check your launch config contains both?
There was a problem hiding this comment.
I believe both versions are supposed to be part of the resolved TP: 2.10.1 explicitly changed here, and 2.9.1 as a transitive dependency of LSP4E. Can you check your resolved TP contains both? Then can you check your launch config contains both?
Indeed the TP contains both. Nevertheless PDE seems to fail to wire the lsp4j-bundle to the old gson-bundle. gson isn't a singleton, so this look like a bug in PDE to me.
No description provided.