Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved release notes #1270

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Improved release notes #1270

merged 2 commits into from
Feb 27, 2023

Conversation

tivervac
Copy link
Contributor

This PR contains two commits.

  • One that fixes typos, mostly spotted by Grammarly.
  • The one important to me, is the addition of the embedded maven update in the 2.x line

For context, we have an eclipse project where we usually run mvn through mvnw on the CLI. However, developers can also use launch profiles in Eclipse, but these use the embedded maven. Recently, I updated our maven to 3.9.0 and our maven-enforcer rule to enforce 3.9.0 as well. This made it impossible to run our launch profile in Eclipse, as Eclipse uses the embedded maven provided by m2e.

Regarding this context, I had a question, does m2e participate in SimRel? Or is it part of JDT? How can I know what m2e version is used by a certain Eclipse (or JDT) version without installing that Eclipse. I was able to find the embedded maven version that's being used in the code, but I couldn't find what m2e version is used in Eclipse.

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the typos and enhancing the release notes.

By the way you can also see the version of the embedded runtime in the bottom of the Main tab of a Maven laucnh-config.
With a recent snapshot it for example says Maven Runtime: EMBEDDED (3.8.7/ ....

Alternatively in the preferences -> Maven -> Installation, the details of the embedded installation show the version of maven and the o.e.m2e.maven.runtime plugin (which contains the embedded maven).

@HannesWell HannesWell merged commit c70445e into eclipse-m2e:master Feb 27, 2023
@HannesWell
Copy link
Contributor

Regarding this context, I had a question, does m2e participate in SimRel? Or is it part of JDT? How can I know what m2e version is used by a certain Eclipse (or JDT) version without installing that Eclipse. I was able to find the embedded maven version that's being used in the code, but I couldn't find what m2e version is used in Eclipse.

Yes M2E participates in the Eclipse SimRel as standalone project.
If you want to know the embedded Maven version in a Eclipse release, you can for example look into
https://download.eclipse.org/releases/2022-12/202212071000/plugins/ and check the version of the org.eclipse.m2e.maven.runtime plugin. Since M2E 2.0, the version of that Plugin matches the version of the embedded Maven-Runtime.

And if you are interested when Maven 3.9 will be available, I recommend to follow #1238.
But this will not land in Eclipse 2022-03, but probably in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants