Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling errors in user-visible error messages #1295

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

robstryker
Copy link

No description provided.

@mickaelistria
Copy link
Contributor

@robstryker can you please sign the ECA, or make sure you're using the same email address between your commit and your Eclipse account?
@laeubi See, the baseline hint here is incorrect, it recommends +0.0.100 while m2e would be happy with +0.0.1.

@HannesWell
Copy link
Contributor

@laeubi See, the baseline hint here is incorrect, it recommends +0.0.100 while m2e would be happy with +0.0.1.

I believe that's simply the default of the baseline plugin? Since we are not providing maintenance releases it is not necessary, but on the other hand I think it does not harm to do +100 and we would be prepared, just in case we do it some day.

@laeubi
Copy link
Member

laeubi commented Mar 4, 2023

@mickaelistria can you explain what is particular wrong in this suggestion? I just used this as it is very common for eclipse (platform), but of course every change (including +1) is acceptable and would resolve the error here.

@HannesWell currently it is not configurable but I'll just add a config option now, in the end it doesn't matter much, the idea behind larger increments is just that if you maintain different branches you can increment there by smaller values if you want prepare a new artifact, but thats more a deployment issue as currently there is no easy way to only deploy a single artifact.

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 4a75650. ± Comparison against base commit b27d023.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Mar 4, 2023

@mickaelistria now +1 is suggested for m2e ...

Signed-off-by: Rob Stryker <stryker@redhat.com>
@laeubi laeubi merged commit 346aa34 into eclipse-m2e:master Mar 6, 2023
@laeubi
Copy link
Member

laeubi commented Mar 6, 2023

@robstryker thanks for looking into this and providing a patch,

@robstryker
Copy link
Author

It was a small thing, I know, but every contribution helps! Glad to participate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants