Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying Security Best Practices (#1351) #1352

Merged
merged 1 commit into from May 17, 2023
Merged

Applying Security Best Practices (#1351) #1352

merged 1 commit into from May 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2023 •
edited by ghost
Loading

resolve: #1351

@ghost
Copy link
Author

ghost commented Apr 18, 2023

Hi,

as far I have checked out the failure seems to be from a flaky test

Thanks,

@github-actions
Copy link

github-actions bot commented Apr 24, 2023 •
edited
Loading

Test Results

  99 files   -   99    99 suites   - 99   13m 46s ⏱️ - 13m 9s
620 tests ±    0  612 ✔️ ±    0  8 💤 ±0  0 ❌ ±0 
620 runs   - 620  612 ✔️  - 612  8 💤  - 8  0 ❌ ±0 

Results for commit b336ec1. ± Comparison against base commit 7b340f7.

♻️ This comment has been updated with latest results.

HannesWell
HannesWell approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.
And dependabot will handle updates. Will be interesting to see if it also updates the version comment.

@HannesWell HannesWell merged commit 787b3df into eclipse-m2e:master May 17, 2023
@HannesWell
Copy link
Contributor

And dependabot will handle updates. Will be interesting to see if it also updates the version comment.

It indeed does it. Great!
See #1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security Best Practices
1 participant
@HannesWell