Keep external annotations paths when updating the project configuration (fixes #391) #1635
Conversation
|
@sebthom can you squash your commits and add a commit message that described the current and improved state? |
|
@laeubi done |
|
@HannesWell @laeubi I would greatly appreciate it if this could be included in the next m2e release. 🤞 |
Prior to this commit, the manually configured external annotation paths for the "JRE System Library" and "Maven Dependencies" classpath entries of an m2e managed Eclipse project were being unset when m2e updated the Eclipse project configuration, e.g. due to changes in the underlying Maven project or due to manual execution of "Maven -> Update project...". This commit ensures that the external annotation path settings are still present after m2e updated the Eclipse project configuration. Fixes #391
There was a problem hiding this comment.
@sebthom thank you for this contribution, it looks good.
I just reworked it a bit to reduce code-duplication and to stream-line the creation of new classpath-entries, but the behavior should be the same (as your tests shows).
Btw. if you are concerned about changes in the configuration due to automated updates, the PR #1664 might be interesting for you.
HannesWell
changed the title
|
@HannesWell Looks good to me. Thanks for reviewing/updating! |
Great. Thanks for the fast feedback. |
Prior to this commit, the manually configured external annotation paths for the "JRE System Library" and "Maven Dependencies" classpath entries of an m2e managed Eclipse project were being unset when m2e updated the Eclipse project configuration, e.g. due to changes in the underlying Maven project or due to manual execution of "Maven -> Update project...".
This commit ensures that the external annotation path settings are still present after m2e updated the Eclipse project configuration.
Fixes #391