Consider the settings files location in project configuration #1675
+49
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 324 files ±0 324 suites ±0 52m 20s ⏱️ - 3m 35s For more details on these errors, see this check. Results for commit 8512738. ± Comparison against base commit f81e6c5. ♻️ This comment has been updated with latest results. |
|
Does this contain parts not already submitted in other PRs or can this be closed? |
laeubi
force-pushed
the
consider_settings_files_in_project_config
branch
from
7125782 to
c0f79b4
Compare
I rebased and updated this now. |
Currently the settings files are not considered when grouping projects by there project configuration. As the settings files can have an impact they should be considered when grouping projects. Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi
force-pushed
the
consider_settings_files_in_project_config
branch
from
c0f79b4 to
8512738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the settings files are not considered when grouping projects by there project configuration.
As the settings files can have an impact they should be considered when grouping projects.
This is part of
after further investigation I'm not sure if it is required or useful at all and if not
is actually enough, because if the multi module basedir is the same the settings needs also be the same, the same is true as well for profiles and user properties, so the main question would be if there are cases where the settings are defined differently other than
maven.configor m2e preferences.