fix: Remove call to print WEBPACK_CONFIG_PATH when updating static assets #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
force-pushed
the
timmc/depr-webpack-print
branch
from
6412c20 to
5b58405
Compare
…sets This setting was removed from edxapp base configs in openedx/edx-platform#36494 and one of these lines started failing with "CommandError: WEBPACK_CONFIG_PATH not found in settings." We don't actually need to print any *particular* setting here; see comment for why we're making this call at all. So here I change it to use a setting that is more unlikely to go away any time soon. Also, add some "comments" to help draw attention to the comment higher up, as well as a little more explanation of the situation.
timmc-edx
force-pushed
the
timmc/depr-webpack-print
branch
from
5b58405 to
d429662
Compare
dianakhuang
approved these changes
Apr 9, 2025
dianakhuang
reviewed
Apr 9, 2025
| @@ -10,12 +10,16 @@ export JS_ENV_EXTRA_CONFIG={} | |||
| # We need to make a call to a management command before running webpack because proctoring runs a webpack | |||
| # webworker that only gets built if the proctoring djangoapp writes out a `workers.json`: | |||
| # https://github.com/openedx/edx-proctoring/blob/73c7f55e2be91324fa07fec6e6ac0a667fdd8412/edx_proctoring/apps.py#L4 | |||
| # We know that `print_setting` will load settings and apps, which is what we | |||
| # actually need. Yes, this is absurd. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting was removed from edxapp base configs in openedx/edx-platform#36494 and one of these lines started failing with "CommandError: WEBPACK_CONFIG_PATH not found in settings."
We don't actually need to print any particular setting here; see comment for why we're making this call at all. So here I change it to use a setting that is more unlikely to go away any time soon.
Also, add some "comments" to help draw attention to the comment higher up, as well as a little more explanation of the situation.
Make sure that the following steps are done before merging: