Skip to content

workaround(s) to suppress DEP0066 warnings #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2019
Merged

workaround(s) to suppress DEP0066 warnings #1417

merged 1 commit into from
Sep 30, 2019

Conversation

colthreepv
Copy link
Contributor

@colthreepv colthreepv commented Sep 30, 2019 •
edited by zube bot
Loading

I wrapped req._headers calls in a ternary operator to not access req._headers in Node 12.x and above.

REF: #1073

Checklist

  • Implement code

@Qard
Copy link
Contributor

Qard commented Sep 30, 2019

jenkins run the tests please

@Qard Qard added backport:2.x This PR should be backported to the 2.x branch [zube]: In Review enhancement labels Sep 30, 2019
@Qard Qard merged commit 1883e34 into elastic:master Sep 30, 2019
@colthreepv colthreepv mentioned this pull request Oct 2, 2019
Merged
@trentm trentm mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
backport:2.x This PR should be backported to the 2.x branch enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colthreepv @Qard