change go version to 1.23.7 #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
added
the
Team:Elastic-Agent-Data-Plane
VihasMakwana
requested review from
faec and
leehinman
and removed request for
a team
kruskall
approved these changes
Mar 20, 2025
|
/test |
1 similar comment
|
/test |
leehinman
approved these changes
Mar 20, 2025
mauri870
approved these changes
Mar 20, 2025
Merged
VihasMakwana
added a commit
that referenced
this pull request
Apr 2, 2025
Follows #210 beats 8.x is on go 1.23.6, whereas elastic-agent-system-metrics's go.mod is on 1.23.7 The [test cases are failing](https://buildkite.com/elastic/beats-xpack-agentbeat/builds/10319#0195e73f-5a26-4c7b-8050-ac1d129a0d4f) due to mismatch of go versions on [backport PR](elastic/beats#43423). I think the best thing to do here is to change elastic-agent-system-metrics's go.mod to 1.23.0, rather than updating the backport PR. If anyone has a better suggestion, feel free to share.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kruskall pointed out that libraries should support the minimum supported version to avoid any effects for downstream users. This PR change should keep CI happy while meeting the minimum version constraints.