Sort simplification #6824
Merged
Sort simplification #6824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OrManySerializationHelper
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization
This was referenced Oct 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization
This was referenced Oct 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization
stevejgordon
added a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Oct 26, 2022
* Code-gen updated to simplify away SortCombinations * Prefer type deserialization rather than activator utilities on SingleOrManySerializationHelper * Add manual converter for FieldSort until shortcut properties are code-generated. * Manual converter for SortOptions to handle union variations of SortCombinations * Add tests for SortOptions serialization Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve usability by simplifying away SortCombinations union.