Skip to content

[Backport 8.3] Fix types and naming during code-gen of internally tagged unions #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public Analyzers(IDictionary<string, IAnalyzer> container) : base(container)
{
}

public void Add(string name, IAnalyzer analyzers) => BackingDictionary.Add(name, analyzers);
public void Add(string name, IAnalyzer analyzer) => BackingDictionary.Add(name, analyzer);
}

public sealed partial class AnalyzersDescriptor : IsADictionaryDescriptor<AnalyzersDescriptor, Analyzers, string, IAnalyzer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public CharFilterDefinitions(IDictionary<string, ICharFilterDefinition> containe
{
}

public void Add(string name, ICharFilterDefinition charFilterDefinitions) => BackingDictionary.Add(name, charFilterDefinitions);
public void Add(string name, ICharFilterDefinition charFilterDefinition) => BackingDictionary.Add(name, charFilterDefinition);
}

public sealed partial class CharFilterDefinitionsDescriptor : IsADictionaryDescriptor<CharFilterDefinitionsDescriptor, CharFilterDefinitions, string, ICharFilterDefinition>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public Normalizers(IDictionary<string, INormalizer> container) : base(container)
{
}

public void Add(string name, INormalizer normalizers) => BackingDictionary.Add(name, normalizers);
public void Add(string name, INormalizer normalizer) => BackingDictionary.Add(name, normalizer);
}

public sealed partial class NormalizersDescriptor : IsADictionaryDescriptor<NormalizersDescriptor, Normalizers, string, INormalizer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public TokenFilterDefinitions(IDictionary<string, ITokenFilterDefinition> contai
{
}

public void Add(string name, ITokenFilterDefinition tokenFilterDefinitions) => BackingDictionary.Add(name, tokenFilterDefinitions);
public void Add(string name, ITokenFilterDefinition tokenFilterDefinition) => BackingDictionary.Add(name, tokenFilterDefinition);
}

public sealed partial class TokenFilterDefinitionsDescriptor : IsADictionaryDescriptor<TokenFilterDefinitionsDescriptor, TokenFilterDefinitions, string, ITokenFilterDefinition>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public TokenizerDefinitions(IDictionary<string, ITokenizerDefinition> container)
{
}

public void Add(string name, ITokenizerDefinition tokenizerDefinitions) => BackingDictionary.Add(name, tokenizerDefinitions);
public void Add(string name, ITokenizerDefinition tokenizerDefinition) => BackingDictionary.Add(name, tokenizerDefinition);
}

public sealed partial class TokenizerDefinitionsDescriptor : IsADictionaryDescriptor<TokenizerDefinitionsDescriptor, TokenizerDefinitions, string, ITokenizerDefinition>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public Properties(IDictionary<PropertyName, IProperty> container) : base(contain
{
}

public void Add(string name, IProperty property) => BackingDictionary.Add(name, property);
public void Add(PropertyName propertyName, IProperty property) => BackingDictionary.Add(propertyName, property);
}

public sealed partial class PropertiesDescriptor<TDocument> : IsADictionaryDescriptor<PropertiesDescriptor<TDocument>, Properties, PropertyName, IProperty>
Expand Down