Implement proper deserialization of EsqlQueryResponse
#8062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Mar 25, 2024
|
|
||
| public sealed partial class EsqlQueryResponse | ||
| { | ||
| public byte[] Data { get; init; } |
There was a problem hiding this comment.
Are we gonna expose this more concretely in the future?
There was a problem hiding this comment.
@Mpdreamz The response is modelled like this in the specification:
export class Response {
body: EsqlColumns
}
export type EsqlColumns = ArrayBufferDepending on the "format" query parameter, this buffer might contain JSON, CSV, ... (and even a binary Arrow dataframe in the future). Internally, we call this the "raw API".
The plan is to provide helper functions on top of the raw API for different usecases. Not all clients will implement the same high level helpers, but for .NET I'll definitely want to add at least the "Object API" (aka simple deserialization into source classes) and the "Arrow Dataframe API".
flobernd
added a commit
that referenced
this pull request
Mar 25, 2024
Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd
added a commit
that referenced
this pull request
Mar 25, 2024
Co-authored-by: Florian Bernd <git@flobernd.de>
flobernd
added a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
CustomResponseBuilderto property deserializeEsqlQueryResponse.Additional changes:
RequestParameterswith thepartialmodifier.