This repository was archived by the owner on Jan 31, 2024. It is now read-only.
[elastic] [WIP] Just call packages.getSizes() once.
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getSizes()` is used to get the information about the architecture and the compiler. The return value is constant for specified machine, like `amd64gc` for my laptop.
movie-travel-code
force-pushed
the
performance
branch
from
2030a8b to
2cac4e2
Compare
|
This change is not a big win because
I would like to emphasize why the language server takes longer time to index the repos than #79 (comment), since CL https://go-review.googlesource.com/c/tools/+/190179 put Although the performance improvement is not so much, I think it deserves an optimization about this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSizes()is used to get the information about the architecture andthe compiler. The return value is constant for specified machine, like
amd64gcfor my laptop.