Skip to content
This repository was archived by the owner on Oct 8, 2020. It is now read-only.

[API BREAKING] Remove Xgit.Util.RawParseUtils. #200

Merged
merged 12 commits into from
Oct 13, 2019
Merged

[API BREAKING] Remove Xgit.Util.RawParseUtils. #200

merged 12 commits into from
Oct 13, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Oct 13, 2019

Changes in This Pull Request

Much of this code was brought over from the earlier jgit port and it turns out not to be as useful as I initially thought. Refactored to avoid unnecessary code.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented. n/a
  • There is test coverage for all changes. n/a
  • All cases where a literal value is returned use the cover macro to force code coverage. n/a
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

scouten added 12 commits October 11, 2019 11:19
@scouten
Remove RawParseUtils.parse_hex_* functions.
a2ba7c9 
Not used anywhere.
@scouten
Remove RawParseUtils.header_end/1. Not used anywhere.
5e2d384
@scouten
Remove several more functions that are not used anywhere.
21f3d5a
@scouten
Merge branch 'master' into dead-strip-raw-parse-utils
f570ea6 
* master:
  Refactor how headers are parsed. (#198)
  Move parse_timzeone_offset into PersonIdent. (#197)
  Implement Xgit.Util.ParseCharlist.decode_ambiguous_charlist/1. (#196)
  Deprecate RawParseUtils.parse_base_10/1 in favor of ParseDecimal.from_decimal_charlist/1. (#195)
@scouten
Remove after_prefix/2.
ee1a806
@scouten
Remove header_start/2.
ff35f3a
@scouten
Merge branch 'master' into dead-strip-raw-parse-utils
e30aaf9 
* master:
  Revise PersonIdent to avoid use of RawParseUtils. (#199)
@scouten
Remove RawParseUtils.until_next_lf/1 and 2.
a8320c4
@scouten
Remove next_lf/1 and 2.
a4d673d
@scouten
Remove next/2.
f012bd8
@scouten
Remove decode/1.
ca48345
@scouten
Remove Xgit.Util.RawParseUtils. No longer needed.
f9766b5
@scouten scouten self-assigned this Oct 13, 2019
@scouten scouten merged commit cfd4f16 into master Oct 13, 2019
@scouten scouten deleted the remove-raw-parse-utils branch October 13, 2019 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@scouten scouten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scouten