Skip to content
This repository was archived by the owner on Oct 8, 2020. It is now read-only.

Xgit.Repository.put_ref/3: Add old_value option. #230

Merged
merged 3 commits into from
Nov 23, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Nov 23, 2019

Changes in This Pull Request

This PR adds an old_value option to match the oldvalue parameter on git update-ref.

Closes #225.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes.
  • All cases where a literal value is returned use the cover macro to force code coverage.
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

@scouten scouten self-assigned this Nov 23, 2019
@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #230   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          36     36           
  Lines        1249   1265   +16     
=====================================
+ Hits         1249   1265   +16
Impacted Files Coverage Δ
lib/xgit/repository.ex 100% <100%> (ø) ⬆️
lib/xgit/repository/in_memory.ex 100% <100%> (ø) ⬆️
lib/xgit/repository/on_disk.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ae0e4...7aad820. Read the comment docs.

@scouten scouten merged commit 44574e0 into master Nov 23, 2019
@scouten scouten deleted the put_ref+require_old_value branch November 23, 2019 04:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xgit.Repository.put_ref/2 should have option to require correct old value.
1 participant