Skip to content
This repository was archived by the owner on Oct 8, 2020. It is now read-only.

Back to 100% code coverage. #268

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Back to 100% code coverage. #268

merged 2 commits into from
Dec 30, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Dec 30, 2019

Changes in This Pull Request

Fill in a couple of missing cases in code coverage.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented. n/a
  • There is test coverage for all changes.
  • All cases where a literal value is returned use the cover macro to force code coverage. n/a
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

@scouten scouten self-assigned this Dec 30, 2019
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #268 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #268      +/-   ##
========================================
+ Coverage   99.85%   100%   +0.14%     
========================================
  Files          28     28              
  Lines        1353   1353              
========================================
+ Hits         1351   1353       +2     
+ Misses          2      0       -2
Impacted Files Coverage Δ
lib/xgit/repository/plumbing.ex 100% <0%> (+0.62%) ⬆️
lib/xgit/repository/storage.ex 100% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b41ae1...17b4c32. Read the comment docs.

@scouten scouten merged commit a302d0e into master Dec 30, 2019
@scouten scouten deleted the full-coverage branch December 30, 2019 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant