Skip to content
This repository was archived by the owner on Oct 8, 2020. It is now read-only.

[API BREAKING] ConfigFile APIs are very unlikely to return POSIX errors. #312

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Mar 23, 2020

Changes in This Pull Request

Rather than writing code to handle them, we'll crash if it happens.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes.
  • All cases where a literal value is returned use the cover macro to force code coverage.
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

Rather than writing code to handle them, we'll crash if it happens.
@scouten scouten self-assigned this Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #312 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1642      1642           
=========================================
  Hits          1642      1642           
Impacted Files Coverage Δ
lib/xgit/config_file.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ecf53...d2df1c9. Read the comment docs.

@scouten scouten merged commit aa61b85 into master Mar 23, 2020
@scouten scouten deleted the config-file+no-errors branch March 23, 2020 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant