Allow using protocol list implementation on improper lists #14366
+45
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
Mar 25, 2025
| @@ -483,7 +486,7 @@ defmodule Module.Types.IntegrationTest do | |||
| dynamic( | |||
| %Date{} or %DateTime{} or %NaiveDateTime{} or %Time{} or %URI{} or %Version{} or | |||
| %Version.Requirement{} | |||
| ) or atom() or binary() or float() or integer() or list(term()) | |||
| ) or atom() or binary() or empty_list() or float() or integer() or non_empty_list(term(), term()) | |||
There was a problem hiding this comment.
I wonder if we should format this as maybe_improper_list(term(), term()) instead (and make a public helper for it in descr)
josevalim
reviewed
Mar 25, 2025
| } | ||
|
|
||
| assert_no_warnings(files, consolidate_protocols: true) | ||
| end |
There was a problem hiding this comment.
Ideally, if we can add this to one of the existing tests, it would be better, as they can be expensive!
There was a problem hiding this comment.
I couldn't find the perfect candidate, but maybe we can group regressions here under a single module, replacing the test descriptions by comments?
sabiwara
force-pushed
the
improper-list-protocol
branch
from
5a624f7 to
d097960
Compare
josevalim
approved these changes
May 11, 2025
|
Nice, will merge this one and rebase+fix #14488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #14365