Skip to content

Use empty face instead of inheriting default #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyrus-and opened this issue Dec 6, 2019 · 2 comments
Closed

Use empty face instead of inheriting default #595

cyrus-and opened this issue Dec 6, 2019 · 2 comments

Comments

@cyrus-and
Copy link

Many faces used by this mode inherit the default face, this has the unpleasant consequence that the background is reset in Markdown code blocks with custom background, see for example:

2019-12-06_19-21

My solution is to do something like this:

(custom-set-faces
 `(php-arithmetic-op ((t ())))
 `(php-assignment-op ((t ())))
 `(php-comparison-op ((t ())))
 `(php-function-call ((t ())))
 `(php-object-op ((t ())))
 `(php-paamayim-nekudotayim ((t ())))
 `(php-static-method-call ((t ())))
 `(php-variable-sigil ((t ()))))

But the list is growing longer and longer... Would it be possible to avoid inheriting the default face and use an empty face instead? Would there be any drawbacks?

@zonuexe
Copy link
Member

zonuexe commented Dec 7, 2019

@cyrus-and Thank you for your suggestion.
The (:inherit default) was not important, so I didn't know its side effects.

Let's remove it.

@cyrus-and
Copy link
Author

Awesome, thank you! Tested and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants