Skip to content

Fix chained method indentation for PSR2 style #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2015
Merged

Fix chained method indentation for PSR2 style #239

merged 2 commits into from
Apr 14, 2015

Conversation

syohex
Copy link
Collaborator

@syohex syohex commented Apr 11, 2015

This is related to #237.
@krzysztof-magosa Could you check this version ?

Original

before

With this patch

after

@ejmr
Copy link
Collaborator

ejmr commented Apr 11, 2015

Alternatively, could we address #237 by modifying the definition of the PSR-2 style? I.e. something like:

(c-add-style
  "psr2"
  '("php"
    (c-offsets-alist . ((statement-cont . +)))))

We might also have to change the default value for topmost-intro-cont, but if changing the C-style settings would have the same effect then I think it would be preferable, as it would keep as much PSR-2--related code in the same place instead of having some style-specific logic for a lineup function that we use in multiple styles.

@syohex
Copy link
Collaborator Author

syohex commented Apr 14, 2015

Alternatively, could we address #237 by modifying the definition of the PSR-2 style?

Thanks for information. I'll fix.

@syohex
Copy link
Collaborator Author

syohex commented Apr 14, 2015

Done

@ejmr
Copy link
Collaborator

ejmr commented Apr 14, 2015

Great, thanks!

@metaturso
Copy link

👍 thanks @syohex

syohex added a commit that referenced this pull request Apr 14, 2015
Fix chained method indentation for PSR2 style
@syohex syohex merged commit 049102f into master Apr 14, 2015
@syohex syohex deleted the issue-237 branch April 14, 2015 14:07
@krzysztof-magosa
Copy link

Great job guys, many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants